Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the filename in “Open in browser as” mode #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jtotht
Copy link

@jtotht jtotht commented Feb 11, 2023

The filename may be used even if the user chooses “Open in browser as”. I found two cases when this happens:

  • The user chooses this option, but the browser can’t actually handle the given MIME type, and downloads the file anyway. (This can be used for example to force downloading XPIs or JARs as simple ZIP files.)
  • The file is a PDF file. Firefox uses the filename when the file is subsequently saved from the PDF.js toolbar, as well as in the tab title.

Instead of general types like `Array` and `object`, use specific types
from the @types/chrome NPM package. This modifies only the JSDoc
comments, without any functional changes.
The filename may be used even if the user chooses “Open in browser as”.
I found two cases when this happens:
- The user chooses this option, but the browser can’t actually handle
  the given MIME type, and downloads the file anyway. (This can be used
  for example to force downloading XPIs or JARs as simple ZIP files.)
- The file is a PDF file. Firefox uses the filename when the file is
  subsequently saved from the PDF.js toolbar, as well as in the tab
  title.
@jtotht
Copy link
Author

jtotht commented Mar 4, 2023

Hi @Rob--W, could you please review this? Not super urgent, but it annoys me constantly because I primarily use this extension to force opening PDFs in Firefox, many of which have no human-readable tab titles due to this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant